Linus Torvalds writes: (Summary) On Sun, Jul 8, 2018 at 9:20 AM Herbert Xu <herbert@gondor.apana.org.au> wrote:
Side note - I queried earlier during the discussion about this: how was this code taken despite having clearly never tested on _anything_? was this code taken despite having clearly never tested on _anything_? Code that simply has never had any testing AT ALL should not have gotten in.
AT ALL should not have gotten in.
The use of 'int3' in padding showed the issue, but I don't believe the code could possibly have worked with the nops and fallthroughs.
[...]
- Add missing RETs in x86 aegis/morus.Side note - I queried earlier during the discussion about this: how was this code taken despite having clearly never tested on _anything_? was this code taken despite having clearly never tested on _anything_? Code that simply has never had any testing AT ALL should not have gotten in.
AT ALL should not have gotten in.
The use of 'int3' in padding showed the issue, but I don't believe the code could possibly have worked with the nops and fallthroughs.
