Linus Torvalds writes: (Summary) Even without the problems that we had with incredibly
bad maintainership of the user mode side, the usermode helper had
serious issues with just the fact that user mode itself is disabled by
the suspend/resume process.
the suspend/resume process.
So getting rid of the locking that was added for usermode helper ion the direct file loading path makes a lot of sense.
the direct file loading path makes a lot of sense.
Just saying that "we tried to re-introduce that locking in another form, and that was a mistake, and got reverted" is *not* a reason to then revert the movement.
then revert the movement.
Yes, the movement of the locking might need to be reverted too - but only if it actually shows problems.
only if it actually shows problems.
We should *not* go back to old code "just because".
the suspend/resume process.
So getting rid of the locking that was added for usermode helper ion the direct file loading path makes a lot of sense.
the direct file loading path makes a lot of sense.
Just saying that "we tried to re-introduce that locking in another form, and that was a mistake, and got reverted" is *not* a reason to then revert the movement.
then revert the movement.
Yes, the movement of the locking might need to be reverted too - but only if it actually shows problems.
only if it actually shows problems.
We should *not* go back to old code "just because".