Re: [PATCH] vfs: fix statfs64() returning impossible EOVERFLOW for ...

Linus Torvalds writes: (Summary) wrote:

[...]

So the whole put_compat_statfs64() thing should be
Ack, I'm ok with this simplification.
Ack, I'm ok with this simplification.

[...]

I'm somewhat tempted to get rid of those 'long' in struct kstatfs, I'm ok with this one too.
I'm ok with this one too.

[...]

static int put##type(struct kstatfs *st, struct type __user *p) \ No. Don't do this.
I'm ok with the #define to avoid duplication, but don't bother with the FIT_IN() after you've above successfully argued that it's pointless for anything but f_bsize/frsize.
pointless for anything but f_bsize/frsize.
So if you do the macro to generate the different copyout versions, just use your simplified code for that macro instead.