Linus Torvalds writes: (Summary) Thanks.
Side note: would it perhaps make sense to have that cpus_read_lock/unlock() sequence around the whole reconfiguration section?
section?
Because while looking at that sequence, it looks a bit odd to me that cpu's can come and go in the middle of the nmi watchdog reconfiguration sequence.
reconfiguration sequence.
In particular, what happens if a new CPU is brought up just as the NMI matchdog is being reconfigured? The NMI's have been stopped for the old CPU's, what happens for the new one that came up in between that watchdog_nmi_stop/start?
watchdog_nmi_stop/start?
This may be all obviously safe, I'm just asking for clarification.
Side note: would it perhaps make sense to have that cpus_read_lock/unlock() sequence around the whole reconfiguration section?
section?
Because while looking at that sequence, it looks a bit odd to me that cpu's can come and go in the middle of the nmi watchdog reconfiguration sequence.
reconfiguration sequence.
In particular, what happens if a new CPU is brought up just as the NMI matchdog is being reconfigured? The NMI's have been stopped for the old CPU's, what happens for the new one that came up in between that watchdog_nmi_stop/start?
watchdog_nmi_stop/start?
This may be all obviously safe, I'm just asking for clarification.