Linus Torvalds writes: (Summary) wrote:
I suspect anything that has the SHA extensions should also do unaligned loads efficiently. The whole "aligned only" model is broken. It's just doing two loads from the state pointer, there's likely no point in trying to align it.
point in trying to align it.
So your patch looks fine, but maybe somebody could add the required alignment to the sha256 context allocation (which I don't know where it is).
it is).
But yeah, that other SLOB panic looks unrelated to this.
[...]
would be to align the data properly?I suspect anything that has the SHA extensions should also do unaligned loads efficiently. The whole "aligned only" model is broken. It's just doing two loads from the state pointer, there's likely no point in trying to align it.
point in trying to align it.
So your patch looks fine, but maybe somebody could add the required alignment to the sha256 context allocation (which I don't know where it is).
it is).
But yeah, that other SLOB panic looks unrelated to this.