Linus Torvalds writes: (Summary) It's not strictly "new", though - we've done that for a while,
and if you used /dev/pts/ptmx you'd even have had the *right* path
for a while ;)
for a while ;)
And this exact issue that Stefan is reporting.
And this exact issue that Stefan is reporting.
But nobody ever used /dev/pts/ptmx, so nobody got the right path, and nobody kept an extra reference to the pts mount.
nobody kept an extra reference to the pts mount.
Yes, that's my plan - get rid of the 'struct path' entirely, make 'driver_data' point to just the dentry, and then at TIOCGPTPEER time just re-create the path by looking up the vfsmount again (by doingf that "pts" lookup again)
that "pts" lookup again)
It should all be _fairly_ straightforward, but it's definitely a rather bigger change than that "just fix the path" patch was.
for a while ;)
And this exact issue that Stefan is reporting.
And this exact issue that Stefan is reporting.
But nobody ever used /dev/pts/ptmx, so nobody got the right path, and nobody kept an extra reference to the pts mount.
nobody kept an extra reference to the pts mount.
[...]
in ptmx_open.Yes, that's my plan - get rid of the 'struct path' entirely, make 'driver_data' point to just the dentry, and then at TIOCGPTPEER time just re-create the path by looking up the vfsmount again (by doingf that "pts" lookup again)
that "pts" lookup again)
It should all be _fairly_ straightforward, but it's definitely a rather bigger change than that "just fix the path" patch was.