Linus Torvalds writes: (Summary) On Thu, Nov 30, 2017 at 12:56 PM, NeilBrown <neilb@suse.com> wrote:
This really smells for so many reasons.
This really smells for so many reasons.
Also, that really is starting to be a fairly big stack allocation, and it seems to be used in exactly one place (show_mark_fhandle), which makes me go "why is that on the stack anyway?". Could we just allocate a buffer at open time or something? Linus
Linus
Linus
[...]
+#define MAX_HANDLE_SZ 200This really smells for so many reasons.
This really smells for so many reasons.
Also, that really is starting to be a fairly big stack allocation, and it seems to be used in exactly one place (show_mark_fhandle), which makes me go "why is that on the stack anyway?". Could we just allocate a buffer at open time or something? Linus
Linus
Linus