Linus Torvalds writes: (Summary) wrote:
done this way,
Was there something else going behind these commits? Because *if* we want to check protection keys, I think we should do that at the vma layer, partly exactly because the exact implementation of protection keys is so architecture-specific, and partly because I don't think it makes sense to check them for every page anyway.
[...]
So do you want to do a straight revert of these that went in for 4.15: I think that's the right thing to do, but would want to verify that there are no *other* issues than just the attempt at PKRU. The commit message does talk about PAGE_USER, and as mentioned I do think that's a good thing to check, I just don't think it should be done this way,done this way,
Was there something else going behind these commits? Because *if* we want to check protection keys, I think we should do that at the vma layer, partly exactly because the exact implementation of protection keys is so architecture-specific, and partly because I don't think it makes sense to check them for every page anyway.