Quantcast
Channel: lkml.org : Shesha Sreenivasamurthy
Viewing all articles
Browse latest Browse all 1267

Re: [tip:perf/urgent] perf/core: Fix lock inversion between perf,t ...

$
0
0
Linus Torvalds writes: (Summary) That's a subtle gotcha when you cut-and-paste things into the editor when editing a commit message (including the "git rebase -i" or "git commit --amend" kind of editing).
"git commit --amend" kind of editing).
If you just apply it as an email, the hash-marks at the beginning of lines are not seen as comments - it's literally just the editing part that uses them as comments.
that uses them as comments.
I'm afraid this isn't really a git "bug". If you quote code with #ifdef etc, indent it.
you quote code with #ifdef etc, indent it.
Maybe git should have used a different comment scheme, but I have to admit that I think this is the first time I've heard of this issue causing problems in practice.

Viewing all articles
Browse latest Browse all 1267

Trending Articles