Linus Torvalds writes: (Summary) wrote:
I don't think that a revert is appropriate.
I don't think that a revert is appropriate.
But perhaps just a single printk() or something if the user does *not* specify the version explicitly? Just saying something like We used to default to 1.0, we now default to 3.0, if you want old defaults, use "vers=1.0"
defaults, use "vers=1.0"
Oh, looking at that version parsing code, I think we also need to fix that legacy "ver=1" thing (ver without the 's') which now silently ignores "ver=1" as being the "default", even though it's not.
[...]
revert should be done or not.I don't think that a revert is appropriate.
I don't think that a revert is appropriate.
But perhaps just a single printk() or something if the user does *not* specify the version explicitly? Just saying something like We used to default to 1.0, we now default to 3.0, if you want old defaults, use "vers=1.0"
defaults, use "vers=1.0"
Oh, looking at that version parsing code, I think we also need to fix that legacy "ver=1" thing (ver without the 's') which now silently ignores "ver=1" as being the "default", even though it's not.