Quantcast
Channel: lkml.org : Shesha Sreenivasamurthy
Viewing all articles
Browse latest Browse all 1267

Re: [PATCH] radix-tree: must check __radix_tree_preload() return value

$
0
0
Linus Torvalds writes: (Summary) wrote:

[...]

EXPORT_SYMBOL(idr_preload);
Is there a reason for the "ret" variable that is entirely mis-named, since it's never actually used as a return value?
since it's never actually used as a return value?
(Sure. We should name variables by the data they contain or how they are used, not by "it was the return value of a function").
was the return value of a function").
In other words, why isn't this just
In other words, why isn't this just
        if (__radix_tree_preload(..))
                preempt_disable();          * ida_get_new() can return -EAGAIN, prompting the caller
>

Viewing all articles
Browse latest Browse all 1267

Trending Articles