Re: [PATCH 2/2 v2] sched/wait: Introduce lock breaker in wake_up_p ...
Linus Torvalds writes: (Summary) wrote:[...] patch probably still is. I haven't had time to look at it any more (trying to merge the pull requests that came in today instead), but the more I think...
View ArticleRe: [PATCH 0/1] devpts: use dynamic_dname() to generate proc name
Linus Torvalds writes: (Summary) With TIOCGPTPEER we have a nice way to get the pts file descriptor, but the "normal" way to get to it involves opening a path given by ptsname(), so we en dup in the...
View ArticleRe: [PATCH 2/2 v2] sched/wait: Introduce lock breaker in wake_up_p ...
Linus Torvalds writes: (Summary) Even the add_page_wait_queue() thing, which looks oh-so-generic, really only waits on PG_locked. really only waits on PG_locked. And the PG_writeback case never really...
View ArticleRe: [PATCH 2/2 v2] sched/wait: Introduce lock breaker in wake_up_p ...
Linus Torvalds writes: (Summary) It's wrong for several reasons: It's wrong for several reasons: - because it's unfair: threads that want to lock get put behind threads that just want to see the...
View ArticleRe: Kernels v4.9+ cause short reads of block devices
Linus Torvalds writes: (Summary) On Wed, Aug 23, 2017 at 2:01 PM, Andreas Dilger <adilger@dilger.ca> Yes, if you use a signed number for the index, it does wrap at 8TB, but you really shouldn't...
View ArticleRe: [PATCH 2/2 v2] sched/wait: Introduce lock breaker in wake_up_p ...
Linus Torvalds writes: (Summary) wrote:[...] So how about just this fairly trivial patch? So I just committed that trivial patch, because I think it's right, but more importantly because I think I...
View ArticleRe: [PATCH 2/2 v2] sched/wait: Introduce lock breaker in wake_up_p ...
Linus Torvalds writes: (Summary) On Sun, Aug 27, 2017 at 2:40 PM, Linus Torvalds<torvalds@linux-foundation.org> wrote:[...] End result: page is unlocked, CPU3 is waiting, nothing will wake CPU3...
View ArticleRe: [PATCH 2/2 v2] sched/wait: Introduce lock breaker in wake_up_p ...
Linus Torvalds writes: (Summary) So the page locking code is racy because you could have this: So the page locking code is racy because you could have this: - another cpu does the unlock_page() and...
View ArticleLinux 4.13-rc7
Linus Torvalds writes: (Summary) You can scan the shortlog, nothing stands out to me right now. the shortlog, nothing stands out to me right now. Linus Linus--- Aaron Ma (1): Input: trackpoint - add...
View ArticleRe: [PATCH 2/2 v2] sched/wait: Introduce lock breaker in wake_up_p ...
Linus Torvalds writes: (Summary) Right now we basically do: - clear lock bit and atomically test if contended (and we play games with bit numbering to do that atomic test efficiently) with bit...
View ArticleRe: [PATCH 2/2 v2] sched/wait: Introduce lock breaker in wake_up_p ...
Linus Torvalds writes: (Summary) */ -static void __wake_up_common(struct wait_queue_head *wq_head, unsigned int mode, - int nr_exclusive, int wake_flags, void *key) +static int __wake_up_common(struct...
View ArticleRe: printk: what is going on with additional newlines?
Linus Torvalds writes: (Summary) wrote: [...] (it's not a bad requirement, but it did change behavior) Oh, it changed behavior, yes (and for kernel code we do that, and require people to change)....
View ArticleRe: printk: what is going on with additional newlines?
Linus Torvalds writes: (Summary) We've done that before to force people to fix their code. We've done that before to force people to fix their code. I'm actually upset that EVEN NOW (and it's been,...
View ArticleRe: printk: what is going on with additional newlines?
Linus Torvalds writes: (Summary) And hide it not as a explicit "char buffer[80]]" allocation, but as a "struct line_buffer" or similar, so that "struct line_buffer" or similar, so that (a) people don't...
View ArticleRe: kvm splat in mmu_spte_clear_track_bits
Linus Torvalds writes: (Summary) Because either (a) you're working with virtual addresses, and you should be able to work on that virtual layer work on that virtual layer (b) you're actually working...
View ArticleRe: [RFC PATCH] mm/rmap: do not call mmu_notifier_invalidate_page() v3
Linus Torvalds writes: (Summary) On Tue, Aug 29, 2017 at 12:05 PM, J=C3=A9r=C3=B4me Glisse <jglisse@redhat.c= om> No no no. Didn't you learn *anything* from the bug? Didn't you learn *anything*...
View ArticleRe: [RFC PATCH] mm/rmap: do not call mmu_notifier_invalidate_page() v3
Linus Torvalds writes: (Summary) And yes, this means that it will be unconditional and regardless of whether anything happened) whether anything happened) And then you can check if something actually...
View ArticleRe: kvm splat in mmu_spte_clear_track_bits
Linus Torvalds writes: (Summary) I'm surprised that try_to_unmap_one didn't hold any locks earlier. try_to_unmap_one didn't hold any locks earlier. In fact, I think at least some of them *did* already...
View ArticleRe: [RFC PATCH] mm/rmap: do not call mmu_notifier_invalidate_page() v3
Linus Torvalds writes: (Summary) So to handle the powernv/npu-dma.c, iommu/amd_iommu_v2.c and ommu/intel-svm.c correctly, _and_ get he KVM case right, we probably need to: need to: - replace the...
View ArticleRe: printk: what is going on with additional newlines?
Linus Torvalds writes: (Summary) For example, you try to handle that nesting with printk_context(), and nothing when an interrupt happens. nothing when an interrupt happens. But that is fundamentally...
View Article