Re: [PATCH 07/34] x86/entry/32: Restore segments before int registers
Linus Torvalds writes: (Summary) So then the whole "restore segments early" must be wrong, because *that* path must get it all right too, no? *that* path must get it all right too, no? And it appears...
View ArticleRe: RANDSTRUCT structs need linux/compiler_types.h (Was: [nfsd4] p ...
Linus Torvalds writes: (Summary) wrote:[...] __attribute((...)) can be placed after 'struct'. That avoids the actual bug, but it wouldn't have helped _find_ the problem in the first place. problem in...
View ArticleRe: [PATCH 07/34] x86/entry/32: Restore segments before int registers
Linus Torvalds writes: On Mon, Mar 5, 2018 at 12:38 PM, Brian Gerst <brgerst@gmail.com> wrote: [...] There already is a test: single_step_syscall.c Ahh, good. So presumably Joerg actually did...
View ArticleRe: [PATCH 07/34] x86/entry/32: Restore segments before int registers
Linus Torvalds writes: (Summary) wrote: [...] previous versions which was return to user with kernel-cr3 :) Ahh. The NX protection to guarantee that you don't return to user mode was really good on...
View ArticleRe: [PATCH 7/7] RCU, workqueue: Implement rcu_work
Linus Torvalds writes: (Summary) The rcu_call() part fundamentally will happen on any CPU, and sure, it could then schedule the work on something else, but that doesn't sound like a particularly sound...
View ArticleRe: [PATCH 5/9] x86/dumpstack: Improve opcodes dumping in the Code ...
Linus Torvalds writes: (Summary) On Tue, Mar 6, 2018 at 1:49 AM, Borislav Petkov <bp@alien8.de> wrote: [...] on the cmdline a new buffer gets allocated. Are these always serialized? For oopses, I...
View ArticleRe: [PATCH net-next] modules: allow modprobe load regular elf binaries
Linus Torvalds writes: (Summary) wrote: [...] [,,] [,,] I like this, but I have one request: can we make sure that this action is visible in the system messages? is visible in the system messages? When...
View ArticleRe: [PATCH net-next] modules: allow modprobe load regular elf binaries
Linus Torvalds writes: (Summary) We've been *so* much better off moving most of the module loading logic to the kernel, we should not go back in the old broken direction. direction. I do *not* want the...
View ArticleRe: VLA removal (was Re: [RFC 2/2] lustre: use VLA_SAFE)
Linus Torvalds writes: (Summary) It generates much more code, and much _slower_ code (and more fragile code), than just using a fixed key size would have done. key size would have done. Ok, so...
View ArticleRe: [PATCH] vsprintf: Make "null" pointer dereference more robust
Linus Torvalds writes: (Summary) We'll still take the fauly, still do vmalloc fault filling, still do a *lot* of potentially really complicated things. complicated things. Guys, stop this idiocy. They...
View ArticleRe: Simplifying our RCU models
Linus Torvalds writes: (Summary) wrote:[...] board with changing these various names? I really would prefer to not see massive re-naming unless there is a really good reason for it. really good reason...
View ArticleRe: [PATCH] x86/vsyscall/64: Drop "native" vsyscalls
Linus Torvalds writes: On Wed, Mar 7, 2018 at 11:12 AM, Andy Lutomirski <luto@kernel.org> wrote: [...] years, and nothing has gone wrong. Delete it. Ack. Ack. I guess we';ll hear if anybody might...
View ArticleRe: Invalid /proc//fd/{0,1,2} symlinks with TIOCGPTPEER
Linus Torvalds writes: (Summary) Why are you using a bind mount in the first place? Right now path_pts() just does ret = path_parent_directory(path); ret = path_parent_directory(path); and that simply...
View ArticleRe: [PATCH 5/9] x86/dumpstack: Improve opcodes dumping in the Code ...
Linus Torvalds writes: On Wed, Mar 7, 2018 at 5:25 AM, Josh Poimboeuf <jpoimboe@redhat.com> wrote: [...] least, reduce its possible range to a reasonable max?) Ack. Just limit it to 64 bytes max...
View ArticleRe: [PATCH] docs: clarify security-bugs disclosure policy
Linus Torvalds writes: (Summary) We also don't explicitly disclose the discussion of the patches or the report, although part of it mayt obviously become more or less public for other reasons. or less...
View ArticleRe: [PATCH] [v2] docs: clarify security-bugs disclosure policy
Linus Torvalds writes: That patch looks fine to me, avoiding any terms that might be misunderstood, and being pretty straightforward. misunderstood, and being pretty straightforward. I'm guessing this...
View ArticleRe: [PATCH] vsprintf: Make "null" pointer dereference more robust
Linus Torvalds writes: (Summary) It _does_ affect plain %p. You're correct that it doesn't affect %px and %pK, since those never printed out (null) in the first place. printed out (null) in the first...
View ArticleRe: [PATCH] vsprintf: Make "null" pointer dereference more robust
Linus Torvalds writes: (Summary) wrote:[...] It not only affects %p, but it also affects %pS and friends (sSfFB), Looking around at the x86 panic thing, %p doesn't matter that much, but %p[sSfFB]...
View ArticleRe: [PATCH 5/9] x86/dumpstack: Improve opcodes dumping in the Code ...
Linus Torvalds writes: (Summary) wrote: [...] + unsigned int code_prologue = OPCODE_BUFSIZE * 43 / OPCODE_BUFSIZE; Heh. Heh. That's a very odd way of writing "43". That's a very odd way of writing...
View ArticleRe: [PATCH] staging: vchiq_arm: Clear VLA warning
Linus Torvalds writes: (Summary) On Fri, Mar 9, 2018 at 10:35 AM, Kees Cook <keescook@chromium.org> wrote: [...] seems like a raw "64" for the array size can be used instead. That's 768 bytes of...
View Article