Linus Torvalds writes: (Summary) wrote:
Yes, that would be worse.
Yes, that would be worse.
I was thinking that maybe we could have a fixed "encrypt" bit in our PTE, and then replace that "software bit" with whatever the real hardware mask is (if any).
hardware mask is (if any).
Because it's nasty to have these constants that _used_ to be constants, and still _look_ like constants, suddely do stupid memory reads from random kernel data.
reads from random kernel data.
So _this_ is the underflying problem:
So _this_ is the underflying problem:
#define _PAGE_ENC (_AT(pteval_t, sme_me_mask))
#define _PAGE_ENC (_AT(pteval_t, sme_me_mask))
because that is simply not how the _PAGE_xyz macros should work!
[...]
the _PAGE_* macros and that's just crap.Yes, that would be worse.
Yes, that would be worse.
I was thinking that maybe we could have a fixed "encrypt" bit in our PTE, and then replace that "software bit" with whatever the real hardware mask is (if any).
hardware mask is (if any).
Because it's nasty to have these constants that _used_ to be constants, and still _look_ like constants, suddely do stupid memory reads from random kernel data.
reads from random kernel data.
So _this_ is the underflying problem:
So _this_ is the underflying problem:
#define _PAGE_ENC (_AT(pteval_t, sme_me_mask))
#define _PAGE_ENC (_AT(pteval_t, sme_me_mask))
because that is simply not how the _PAGE_xyz macros should work!