Re: [PATCH] x86/mm: Unbreak modules that rely on external PAGE_KER ...
Linus Torvalds writes: (Summary) It should be something that is so core - but also so _meaningful_ - that using it is a big flag that you're not just a random driver or something. you're not just a...
View ArticleRe: [PATCH] x86/mm: Unbreak modules that rely on external PAGE_KER ...
Linus Torvalds writes: (Summary) wrote: [...] the _PAGE_* macros and that's just crap. Yes, that would be worse. Yes, that would be worse. I was thinking that maybe we could have a fixed "encrypt" bit...
View ArticleRe: [PATCH] x86/mm: Unbreak modules that rely on external PAGE_KER ...
Linus Torvalds writes: (Summary) Of course, that at least doesn't trigger for the simple cases - only _PAGE_CACHE_WP and _PAGE_NOCACHE end up triggering that "cachemode2protval()" case....
View ArticleRe: [nfsd4] potentially hardware breaking regression in 4.14-rc an ...
Linus Torvalds writes: (Summary) In pretty much all cases this is a sign of a nasty BIOS problem, though, and you may want to look into a firmware update from the vendor for that. vendor for that. But...
View ArticleRe: [PATCH 2/3] Improve fairness when locking the per-superblock s ...
Linus Torvalds writes: (Summary) wrote: [...] in soft-lockup warnings. This really seems idiotic. This really seems idiotic. Let me rephrase this commit message so that you can see why I think it's...
View ArticleRe: [nfsd4] potentially hardware breaking regression in 4.14-rc an ...
Linus Torvalds writes: (Summary) As Al points out, it can cause absolutely horrendous cache access pattern changes, but it might also be triggering some corruption in case there's a problem with the...
View ArticleRe: [PATCH 3/3] VFS / autofs4: remove kern_path_mountpoint()
Linus Torvalds writes: On Wed, Nov 8, 2017 at 11:20 PM, NeilBrown <neilb@suse.com> wrote: [...] 3 files changed, 2 insertions(+), 133 deletions(-) This one certainly looks lovely, and the...
View ArticleRe: [PATCH 3/3] VFS: close race between getcwd() and d_move()
Linus Torvalds writes: (Summary) The problem is that __d_move() really wants to move the hashes things atomically, but instead of doing that it does a "unhash and then rehash". rehash". How nasty would...
View ArticleRe: [PATCH 2/3] Improve fairness when locking the per-superblock s ...
Linus Torvalds writes: (Summary) Because we do have such a list: the dentry sibling list. sibling list. So what if we instead of using s_anon, we create a "disconnected root", and make all the...
View ArticleRe: [PATCH 3/3] VFS: close race between getcwd() and d_move()
Linus Torvalds writes: (Summary) You've taken the BUG_ON() from __d_rehash() that no longe rmakes any sense (because we just explicitly unhashed it), and replaced it with a BUG_ON() that didn't exist...
View ArticleRe: [nfsd4] potentially hardware breaking regression in 4.14-rc an ...
Linus Torvalds writes: (Summary) Pretty much by definition compiler bugs tend to be about rare situations, so it's some odd special case that triggers. some odd special case that triggers. Since it's...
View ArticleRe: [PATCH] x86: use cpufreq_quick_get() for /proc/cpuinfo "cpu MH ...
Linus Torvalds writes: (Summary) On Thu, Nov 9, 2017 at 2:30 PM, Rafael J. wrote: [...] into account. Yeah, that won't work. Yeah, that won't work. What could work is to do that...
View ArticleRe: Kernel crash in free_pipe_info()
Linus Torvalds writes: (Summary) On Thu, Nov 9, 2017 at 10:07 PM, Simon Brewer <sbrunau@gmail.com> wrote: [...] causing a kernel BUG when attempting to kill the process. Interestingly, some of...
View ArticleRe: [PATCH 3/3] VFS: close race between getcwd() and d_move()
Linus Torvalds writes: (Summary) This looks more palatable to me, yes. This looks more palatable to me, yes. It still worries me a bit that we end up having that dangling pprev pointer despite having...
View ArticleRe: [run_timer_softirq] BUG: unable to handle kernel paging reques ...
Linus Torvalds writes: (Summary) It's It's next->pprev = pprev; next->pprev = pprev; in __hlist_del(), and the trapping instruction decodes as in __hlist_del(), and the trapping instruction...
View ArticleRe: [PATCH] .mailmap: Add Maciej W. Rozycki's Imagination e-mail a ...
Linus Torvalds writes: (Summary) wrote: [...] final rc. You sent this as charset=3D"ISO-8859-15" You sent this as charset=3D"ISO-8859-15" Please use UTF-8 instead. Please use UTF-8 instead. It didn't...
View ArticleRe: [PATCH] fs: avoid NULL pointer dereference for nobh on write error
Linus Torvalds writes: (Summary) wrote: [...] one can query for that ?) This is intentional. This is intentional. See the comment above the code you added: See the comment above the code you added: *...
View ArticleRe: [RFC PATCH 0/2] x86: Fix missing core serialization on migration
Linus Torvalds writes: (Summary) On Fri, Nov 10, 2017 at 1:12 PM, Mathieu Desnoyers<mathieu.desnoyers@efficios.com> wrote:[...] Feedback is welcome, We should check with Intel. I would actually...
View ArticleRe: [RFC PATCH 0/2] x86: Fix missing core serialization on migration
Linus Torvalds writes: (Summary) wrote:[...] Manual, Volume 3: System Programming. Oh, I know. Oh, I know. I'm just saying that the Intel docs wrt cross-modifying code are most likely crap and overly...
View ArticleRe: [nfsd4] potentially hardware breaking regression in 4.14-rc an ...
Linus Torvalds writes: (Summary) [ Bringing in the gcc plugin people and the kernel hardening list, since it now is no longer even remotely looking like a nfsd, vfs or filesystem issue any more ]...
View Article