Linus Torvalds writes: (Summary)
This looks more palatable to me, yes.
This looks more palatable to me, yes.
It still worries me a bit that we end up having that dangling pprev pointer despite having dropped the hash list lock, but as long as nobody uses it for anything but that "is it hashed" test without taking the dentry lock, it all *should* be safe.
taking the dentry lock, it all *should* be safe.
Please fix the whitespace, though. This is not how we do function definitions:
This looks more palatable to me, yes.
It still worries me a bit that we end up having that dangling pprev pointer despite having dropped the hash list lock, but as long as nobody uses it for anything but that "is it hashed" test without taking the dentry lock, it all *should* be safe.
taking the dentry lock, it all *should* be safe.
Please fix the whitespace, though. This is not how we do function definitions:
void __d_drop(struct dentry *dentry) {
but otherwise I think this patch is acceptable.